search

shshankjain / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

vp8\encoder\onyx_if.c calls fopen() #186

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What is the expected behavior?
no calls to fopen()

What do you see instead?
calls to fopen()

Could you wrap all debug code in ifdefs?
This is all debugging code, that should not appear in a final product.

There are 3 occurrences that are not ifdef'ed

void vp8_write_yuv_frame(const char *name, YV12_BUFFER_CONFIG *s)
{
    FILE *yuv_file = fopen(name, "ab");
...
For this one, add 
#ifdef OUTPUT_YUV_SRC

There are two with if (0).  Please change to #if 0 or remove the code.

    if (0)
    {
        FILE *f = fopen("gfactive.stt", "a");
        fprintf(f, "%8d %8d %8d %8d %8d\n", cm->current_video_frame, (100 * cpi->gf_active_count) / (cpi->common.mb_rows * cpi->common.mb_cols), cpi->this_iiratio, cpi->next_iiratio, cm->refresh_golden_frame);
        fclose(f);
    }

    if (0)
    {
        char filename[512];
        FILE *recon_file;
        sprintf(filename, "enc%04d.yuv", (int) cm->current_video_frame);
        recon_file = fopen(filename, "wb");
        fwrite(cm->yv12_fb[cm->lst_fb_idx].buffer_alloc,
               cm->yv12_fb[cm->lst_fb_idx].frame_size, 1, recon_file);
        fclose(recon_file);
    }

What version are you using?
v0.9.2-35-ga8a38bc

On what operating system?
Mac

Can you reproduce using the ivfdec or ivfenc tools?
N/A
What command line are you using?

Please provide any additional information below.

Original issue reported on code.google.com by fbarch...@chromium.org on 24 Sep 2010 at 12:30

GoogleCodeExporter commented 9 years ago 
https://review.webmproject.org/#change,597

Original comment by jkoles...@google.com on 29 Sep 2010 at 1:37

GoogleCodeExporter commented 9 years ago

Original comment by albe...@google.com on 8 Mar 2012 at 12:10