search

shshankjain / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

Need to clarify m_size and m_frameSize in Mkvparser.cpp #191

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
GetSize() of Block class returns 4 less than m_size.
We need to clarify this thing up.

Original issue reported on code.google.com by hwasoo...@google.com on 1 Oct 2010 at 5:21

GoogleCodeExporter commented 9 years ago 
I suppose you could rename those operations GetFrameOffset and GetFrameSize.  

m_size is the amount of storage consumed by the EBML Block element.

Member function GetSize returns the amount of storage consumed by the frame 
itself, which is only a subset of total storage consumed by the enclosing Block 
element.

Original comment by matthewj...@google.com on 28 Oct 2010 at 9:00

GoogleCodeExporter commented 9 years ago 
Problem went away when we added support for lacing.  The "payload" part of the 
element is still described by the m_size member variable, but now the actual 
frame(s) is described using its own struct, with its own position and length 
member variables.

Original comment by matthewj...@google.com on 16 Nov 2010 at 6:01

GoogleCodeExporter commented 9 years ago

Original comment by albe...@google.com on 8 Mar 2012 at 12:10