shshankjain / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

Bug in libvpx0.9.2 bool code buffer size initialization #197

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What is the expected behavior? What do you see instead?

In libvpx 0.9.2 release, decoder frame decode funtion uses total frame size to 
intialize the P1 pratition buffer size 

int vp8_decode_frame(VP8D_COMP *pbi)
{
    ....
    if (vp8dx_start_decode(bc, IF_RTCD(&pbi->dboolhuff),
                           data, data_end - data))
}

=>
Should it be replaced by first_partition_length_in_bytes, so the proper zero 
padding bytes are used for P1 partition bool decode. 

int vp8_decode_frame(VP8D_COMP *pbi)
{
    ....
    if (vp8dx_start_decode(bc, IF_RTCD(&pbi->dboolhuff),
                           data, first_partition_length_in_bytes))
}

Use attached test stream, at frame 3 (counting from frame 0) MBA[1, 12]  mbx=1, 
mby= 12, decoder run out P1 buffer data and falsely uses P2 partiton data for 
P1 partition decode.

Plese help to confirm if this is a decoder bug.

Thanks,

Olive

What version are you using? On what operating system?
libvpx0.9.2 

Can you reproduce using the ivfdec or ivfenc tools? What command line are
you using?

Please provide any additional information below.

Original issue reported on code.google.com by olive...@yahoo.com on 7 Oct 2010 at 11:32

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by iss...@webmproject.org on 16 Mar 2011 at 2:51

GoogleCodeExporter commented 9 years ago
This call is still the same, Scott is this an issue?

Original comment by jz...@google.com on 26 Jul 2011 at 1:18

GoogleCodeExporter commented 9 years ago
Olive,

How did you create this file?  It appears to be corrupted.  Was it intentional?

The mode/mv partition does not contain enough valid data for that frame.  Your 
suggestion will not fix the problem, however it will force the decoder to read 
zeros instead of random data.  Either way, the decoder is behaving correctly by 
marking the frame corrupt.

Original comment by slavarn...@google.com on 26 Jul 2011 at 5:50

GoogleCodeExporter commented 9 years ago
We need more information in this issues, please update them. Otherwise they 
will be closed in the next week or so.

thanks 

Original comment by albe...@google.com on 16 Feb 2012 at 9:22

GoogleCodeExporter commented 9 years ago
We have not heard back from this bug in a while, closing it. 

Original comment by albe...@google.com on 7 Mar 2012 at 11:45

GoogleCodeExporter commented 9 years ago

Original comment by albe...@google.com on 8 Mar 2012 at 12:10