Compiler warnings with -Wall

[GoogleCodeExporter]

What version are you using? On what operating system?

$ git show
commit 4d1b0d2a2dff335baedd52bd7de09d55ec10b253
Merge: 5551ef0... 9fb80f7...
Author: John Koleszar <jkoleszar@google.com>
Date:   Fri Nov 5 16:49:17 2010 -0400

    Merge commit 'fix integer promotion bug in partition size check'

    Change-Id: I4081917b46013fa8f4218cade8bd12cb2d013aee

OS X 10.4.11

Can you reproduce using the ivfdec or ivfenc tools? What command line are
you using?

Please provide any additional information below.

Build log...

CC=/usr/bin/gcc-4.0 LD=/usr/bin/gcc-4.0 AS=/usr/local/bin/yasm CFLAGS="-Wall 
-O2 -isysroot /Developer/SDKs/MacOSX10.2.8.sdk -mmacosx-version-min=10.2 -arch 
ppc" CPPFLAGS=-DVPX_CODEC_DISABLE_COMPAT \
                ./configure --target=ppc32-darwin8-gcc   \
                            --enable-vp8 \
                            --disable-examples \
                            --disable-multithread
Configuring selected codecs
  enabling vp8_encoder
  enabling vp8_decoder
Configuring for target 'ppc32-darwin8-gcc'
  enabling ppc32
  enabling altivec
  enabling postproc
Creating makefiles for ppc32-darwin8-gcc libs
Creating makefiles for ppc32-darwin8-gcc docs
make -C ../libvpx
...
    [CC] vp8/encoder/bitstream.c.o
vp8/encoder/bitstream.c: In function 'vp8_pack_bitstream':
vp8/encoder/bitstream.c:1400: warning: suggest parentheses around arithmetic in 
operand of |
vp8/encoder/bitstream.c:1400: warning: suggest parentheses around arithmetic in 
operand of |
vp8/encoder/bitstream.c:1401: warning: suggest parentheses around arithmetic in 
operand of |
vp8/encoder/bitstream.c:1401: warning: suggest parentheses around arithmetic in 
operand of |
vp8/encoder/bitstream.c:1393: warning: 'oh.first_partition_length_in_bytes' is 
used uninitialized in this function
    [CC] vp8/encoder/boolhuff.c.o
    [CC] vp8/encoder/dct.c.o
    [CC] vp8/encoder/encodeframe.c.o
    [CC] vp8/encoder/encodeintra.c.o
    [CC] vp8/encoder/encodemb.c.o
vp8/encoder/encodemb.c: In function 'vp8_optimize_b':
vp8/encoder/encodemb.c:274: warning: 'sz' may be used uninitialized in this 
function
    [CC] vp8/encoder/encodemv.c.o
    [CC] vp8/encoder/ethreading.c.o
    [CC] vp8/encoder/firstpass.c.o
    [CC] vp8/encoder/generic/csystemdependent.c.o
    [CC] vp8/encoder/mcomp.c.o
vp8/encoder/mcomp.c: In function 'vp8_find_best_sub_pixel_step':
vp8/encoder/mcomp.c:320: warning: 'diag' may be used uninitialized in this 
function
    [CC] vp8/encoder/modecosts.c.o
    [CC] vp8/encoder/onyx_if.c.o
    [CC] vp8/encoder/pickinter.c.o
    [CC] vp8/encoder/picklpf.c.o
    [CC] vp8/encoder/psnr.c.o
    [CC] vp8/encoder/quantize.c.o
    [CC] vp8/encoder/ratectrl.c.o
    [CC] vp8/encoder/rdopt.c.o
vp8/encoder/rdopt.c: In function 'vp8_rd_pick_inter_mode':
vp8/encoder/rdopt.c:1410: warning: 'uv_intra_rate_tokenonly' may be used 
uninitialized in this function
    [CC] vp8/encoder/sad_c.c.o
    [CC] vp8/encoder/segmentation.c.o
    [CC] vp8/encoder/tokenize.c.o
    [CC] vp8/encoder/treewriter.c.o
    [CC] vp8/encoder/variance_c.c.o
    [CC] vp8/encoder/temporal_filter.c.o
    [CC] vp8/vp8_dx_iface.c.o
vp8/vp8_dx_iface.c: In function 'vp8_peek_si':
vp8/vp8_dx_iface.c:279: warning: suggest parentheses around arithmetic in 
operand of |
vp8/vp8_dx_iface.c:280: warning: suggest parentheses around arithmetic in 
operand of |
    [CC] vp8/decoder/dboolhuff.c.o
    [CC] vp8/decoder/decodemv.c.o
    [CC] vp8/decoder/decodframe.c.o
vp8/decoder/decodframe.c: In function 'vp8_decode_frame':
vp8/decoder/decodframe.c:859: warning: implicit declaration of function 
'vp8mt_decode_mb_rows'
    [CC] vp8/decoder/dequantize.c.o
    [CC] vp8/decoder/detokenize.c.o
    [CC] vp8/decoder/generic/dsystemdependent.c.o
    [CC] vp8/decoder/onyxd_if.c.o
vp8/decoder/onyxd_if.c: In function 'vp8dx_create_decompressor':
vp8/decoder/onyxd_if.c:118: warning: implicit declaration of function 
'vp8_decoder_create_threads'
vp8/decoder/onyxd_if.c: In function 'vp8dx_remove_decompressor':
vp8/decoder/onyxd_if.c:153: warning: implicit declaration of function 
'vp8_decoder_remove_threads'
    [CC] vp8/decoder/threading.c.o
vp8/decoder/threading.c: In function 'vp8mt_alloc_temp_buffers':
vp8/decoder/threading.c:655: warning: no return statement in function returning 
non-void
vp8/decoder/threading.c:655: warning: control reaches end of non-void function
    [CC] vp8/decoder/idct_blk.c.o
    [CC] vpx_config.c.o
    [AR] libvpx_g.a
    [CP] libvpx.a < libvpx_g.a

Original issue reported on code.google.com by t...@telegraphics.com.au on 8 Nov 2010 at 12:22

[GoogleCodeExporter]

Original comment by iss...@webmproject.org on 16 Mar 2011 at 2:51

[GoogleCodeExporter]

We have worked to get all the warnings out of most platforms.  Currently there 
isn't a ppc development platform that we can use to chase down these warnings.

Original comment by frkoe...@google.com on 21 Mar 2011 at 4:27

• Changed state: WontFix

[GoogleCodeExporter]

Why not assign it to someone who has the PowerPC environment available (I have 
G4 and G5 available indefinitely)?

Original comment by t...@telegraphics.com.au on 21 Mar 2011 at 7:04

[GoogleCodeExporter]

So my statement isn't completely honest.  We do have a ppc system.  But we 
don't have the resources internally to track down and fix these warnings.  As 
warning they are mostly cosmetic.   Sadly not many people are using ppc and 
disappointingly MacOS is dead on ppc.  This is one of the reasons that the 
altivec optimizations are not currently implemented in the build system.  If 
you are interested in submitting patches, I will review and approve them as 
necessary.  Or if you think there is a case for a sizable group of users that 
needs this fixed, let us know and we will consider it.

Original comment by frkoe...@google.com on 21 Mar 2011 at 7:25

[GoogleCodeExporter]

For the record, we're using libvpx 0.9.7 with AltiVec for TenFourFox's WebM 
module. I had to do some hacking to get the loopfilters working and I'm not 
sure what level of disgusting you will find acceptable. However, if there is 
interest in me upstreaming our work, I'll be happy to polish it up some.

Original comment by classi...@floodgap.com on 6 Jan 2012 at 5:53

[GoogleCodeExporter]

Feel free to submit and I'll review and help get the patches cleaned up.  I 
can't comment on the interest level from users.

Original comment by frkoe...@google.com on 6 Jan 2012 at 11:10