Closed GoogleCodeExporter closed 9 years ago
Fix looks ok.. Are there *any* differences between win64 and x64 in this
context? I'm not clear on how you're hitting issue anyway -- when building for
vs8, msvs invokes yasm -f $(PlatformName), which has always been x64 in my
experience. Is this a difference between the Express and full versions maybe?
Original comment by jkoles...@google.com
on 15 Nov 2010 at 8:51
The yasm documentation does not mention -f x64. My build uses -f WIN64 which is
documented in man yasm_objfmts:
WIN64
The Win64 object format produces object files compatible with Microsoft compilers
that target the 64-bit "x64" Windows platform. This format is very similar to the
win32 object format, but produces 64-bit objects.
(This is the case for both yasm 0.8.0.2194 and, from my OS X build, yasm
1.1.0.2352.)
I am not using VS IDE but rather the tools via CLI (in this case from the
Visual Express distribution).
Original comment by t...@telegraphics.com.au
on 15 Nov 2010 at 10:19
Can you try with -f x64? I'm thinking that this may explain your other issue
with crashes on 64 bit windows, since x86_abi_support.asm isn't the only place
where we do something special for x64:
$ grep --include=*.asm -Rl x64 *
vp8/encoder/x86/dct_sse2.asm
vpx_ports/emms.asm
vpx_ports/x86_abi_support.asm
Didn't look in the docs, but this option should be fine in both the versions of
yasm you mention:
$ yasm -f help
Available yasm object formats:
dbg Trace of all info passed to object format module
bin Flat format binary
dosexe DOS .EXE format binary
elf ELF
elf32 ELF (32-bit)
elf64 ELF (64-bit)
coff COFF (DJGPP)
macho Mac OS X ABI Mach-O File Format
macho32 Mac OS X ABI Mach-O File Format (32-bit)
macho64 Mac OS X ABI Mach-O File Format (64-bit)
rdf Relocatable Dynamic Object File Format (RDOFF) v2.0
win32 Win32
win64 Win64
x64 Win64
xdf Extended Dynamic Object
Original comment by jkoles...@google.com
on 17 Nov 2010 at 2:02
John,
Solved both issues, thankyou. I wonder if the requirement for -f x64 with yasm
needs stronger emphasis somewhere, given that the redundant options exist.
yasm man pages obviously need updating too. :/
Original comment by t...@telegraphics.com.au
on 17 Nov 2010 at 4:42
Original comment by iss...@webmproject.org
on 16 Mar 2011 at 2:51
Original comment by agra...@google.com
on 17 Mar 2011 at 4:28
No further change necessary at this time.
Original comment by jkoles...@google.com
on 17 Mar 2011 at 4:43
Original issue reported on code.google.com by
t...@telegraphics.com.au
on 15 Nov 2010 at 4:17