search

shssoichiro / oxipng

Multithreaded PNG optimizer written in Rust
MIT License
2.86k stars 124 forks source link

Wrong Version either Reported or Packaged #637

Closed Obscure2020 closed 2 months ago

Obscure2020 commented 2 months ago

When I download oxipng-9.1.2-x86_64-pc-windows-msvc.zip from the Releases page, the oxipng.exe inside reports that it is version 9.1.1 when I run oxipng -V. This means that either you put version 9.1.1 in a package that was supposed to contain version 9.1.2, or it could mean that version 9.1.2 is erroneously programmed to report 9.1.1.

andrews05 commented 2 months ago

Hi @Obscure2020, sorry about this. I've just redeployed and it looks to be correct now.

(I think this happened because I deployed before the previous workflow had finished. It appeared to be affecting x86_64-windows as well as both the linux-musl packages.)

AlexTMjugador commented 2 months ago

(I think this happened because I deployed before the previous workflow had finished. It appeared to be affecting x86_64-windows as well as both the linux-musl packages.)

Indeed, I can confirm the release deploy workflow is meant to be executed after the usual CI build for it finished, as otherwise it won't be able to fetch the proper binary artifact :+1: