shssoichiro / soifunc

Vapoursynth helper utilities
MIT License
10 stars 0 forks source link

Deprecate duplicate functions, update existing ones #4

Closed LightArrowsEXE closed 1 year ago

LightArrowsEXE commented 1 year ago

This PR does the following:

The biggest "drawback" for the common users of this *func is more reliance on iew-related packages. That said, most of the direct iew usage should be mitigated and abstracted away, so it should not require users learn how to use those functions per se (though of course, in my personal opinion, they should lol). The deprecated functions currently work as wrappers around those instead.

pls2test before merging <3

Setsugennoao commented 1 year ago

Fixed a couple of things.

shssoichiro commented 1 year ago

@Setsugennoao @LightArrowsEXE It looks like vsdenoise.fft3d isn't in the latest published pip version, could I trouble whoever has the ownership to push a new release?

Setsugennoao commented 1 year ago

Sure, i'll do it tomorrow.

shssoichiro commented 1 year ago

I have no idea why git closed this when I pushed up changes. :facepalm:

shssoichiro commented 1 year ago

Oh because git is terrible (for usability) and it pushed my main to light's main because he didn't name his PR branch something other than main. :facepalm:

shssoichiro commented 1 year ago

Now git is saying I don't have permissions to push to light/main, even though I just did it before. I guess I just have to recreate the PR. :facepalm: :facepalm: :facepalm: :facepalm:

Setsugennoao commented 1 year ago

Lol, has happened to me a couple of times. Pushed the changes again btw.