search

shssoichiro / soifunc

Vapoursynth helper utilities
MIT License
10 stars 0 forks source link

Add GoodScaler class that derives KeepArScaler #8

Closed shssoichiro closed 10 months ago

shssoichiro commented 11 months ago

@LightArrowsEXE do you think this is sufficient for what we were discussing in Discord?

shssoichiro commented 10 months ago

Though I also have to ask: why make this a class, as opposed to having users use HybridScaler.scale() and implement some of the logic here in there instead?

HybridScaler is really just supposed to be a helper class, though it could be used on its own. The purpose of GoodResize was to use an opinionated set of scalers that are intended to provide the "best" (subjective) quality currently available (without targeting any specific content type, i.e. so not using Waifu2x). And to keep that call as simple as possible. I want to still be able to just call GoodScaler.scale(clip, 1920, 1080) without needing to specify any other parameters.

(as a note: I still need to test this before merging)

shssoichiro commented 10 months ago

This seems to work based on local testing, though it is blocked on https://github.com/Jaded-Encoding-Thaumaturgy/vs-scale/pull/85