search

shssoichiro / sqlformat-rs

SQL Formatter written in Rust
Apache License 2.0
89 stars 26 forks source link

Latest patch release seems to contain a breaking change #54

Closed jplatte closed 1 month ago

jplatte commented 1 month ago

sqlformat::format now requires a &FormatOptions<_> for its third argument, when it used to take an owned FormatOptions. This makes SQLx fail to compile with that version.

Please consider yanking v0.2.7.

abonander commented 1 month ago

cc https://github.com/launchbadge/sqlx/issues/3544

shssoichiro commented 1 month ago

The version has been yanked. I'd like to avoid this in the future. Are there any suggestions for catching this early? I recall there being a cargo tool to semi-automate this, though I can't remember what it was called.

jplatte commented 1 month ago

You're probably thinking of https://github.com/obi1kenobi/cargo-semver-checks

shssoichiro commented 1 month ago

It looks like the breaking change is difficult to isolate and revert without reverting meaningful changes. As such, I'm moving forward releasing the new version as 0.3.0 instead so that it is properly acknowledged as breaking.