search

shtirlitsDva / Revit-PCF-Exporter

An application for Autodesk Revit for exporting pipe information to PCF file format.
GNU General Public License v3.0
19 stars 7 forks source link

problem to add Flange to valves (pipeaccessory) #50

Open mcindusbim opened 5 months ago

mcindusbim commented 5 months ago

Good morning, I cloned and compiled and modified the .addin file to open it in Revit (no problem). Rename the flange family (Flange weld collar) I can't add the flanges to the valves. can you help me THANKS 2024-05-02_11h23_25

shtirlitsDva commented 5 months ago

Are your valve and flange connectors connected in the family?

On Thu, 2 May 2024, 11.27 mcindusbim, @.***> wrote:

Good morning, I cloned and compiled and modified the .addin file to open it in Revit (no problem). Rename the flange family (Flange weld collar) I can't add the flanges to the valves. can you help me THANKS 2024-05-02_11h23_25.png (view on web) https://github.com/shtirlitsDva/Revit-PCF-Exporter/assets/168081331/d7925c7c-7833-40df-bb26-dbba6eb13cf0

— Reply to this email directly, view it on GitHub https://github.com/shtirlitsDva/Revit-PCF-Exporter/issues/50, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC5QWW7VLA344SNNRKI4NPLZAIBHVAVCNFSM6AAAAABHDLG23KVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3TKMBTGQ3DEOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

mcindusbim commented 5 months ago

Sorry, I'm not sure I understand the question. My valve is connected to the pipes (yes)

mcindusbim commented 5 months ago

Like this 2024-05-02_11h48_40

mcindusbim commented 5 months ago

Do you have an example of a revit project (very simple a pipe, a valve and a flange) that works. I will be able to control what is wrong

shtirlitsDva commented 5 months ago

No, in the family editor, the connectors have to be connected.

On Thu, 2 May 2024, 11.50 mcindusbim, @.***> wrote:

Like this 2024-05-02_11h48_40.png (view on web) https://github.com/shtirlitsDva/Revit-PCF-Exporter/assets/168081331/f5c30f64-0479-4d47-a66f-57ce4a045fb6

— Reply to this email directly, view it on GitHub https://github.com/shtirlitsDva/Revit-PCF-Exporter/issues/50#issuecomment-2090047590, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC5QWWYC3DFS563EVI76MJTZAID5ZAVCNFSM6AAAAABHDLG23KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJQGA2DONJZGA . You are receiving this because you commented.Message ID: @.***>

shtirlitsDva commented 5 months ago

I an not at the computer right now, later. Connectors: https://github.com/shtirlitsDva/Revit-PCF-Exporter/wiki/Preparing-your-model#marking-a-connector-as-primary-and-secondary

On Thu, 2 May 2024, 11.53 mcindusbim, @.***> wrote:

Do you have an example of a revit project (very simple a pipe, a valve and a flange) that works. I will be able to control what is wrong

— Reply to this email directly, view it on GitHub https://github.com/shtirlitsDva/Revit-PCF-Exporter/issues/50#issuecomment-2090056701, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC5QWWZZ3KLQIGBE5FKCGT3ZAIEIDAVCNFSM6AAAAABHDLG23KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJQGA2TMNZQGE . You are receiving this because you commented.Message ID: @.***>

mcindusbim commented 5 months ago

all my family (flange and valve) have a links between connectors 2024-05-02_11h57_15

shtirlitsDva commented 5 months ago

Hi, Better you send me your families (valve and flange) so I can debug the code. The flange must be set (in the FamilyEditor) as a Cap. If it is set as a flange it will disappear when you change edit piping. Regards Michail

On Thu, 2 May 2024 at 12:02, mcindusbim @.***> wrote:

all my family (flange and valve) have a links between connectors 2024-05-02_11h57_15.png (view on web) https://github.com/shtirlitsDva/Revit-PCF-Exporter/assets/168081331/e2e27660-0d33-48e2-b8bb-55b9d808d44d

— Reply to this email directly, view it on GitHub https://github.com/shtirlitsDva/Revit-PCF-Exporter/issues/50#issuecomment-2090073924, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC5QWW2U7ALXCJFHIBDYLRDZAIFKBAVCNFSM6AAAAABHDLG23KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJQGA3TGOJSGQ . You are receiving this because you commented.Message ID: @.***>

mcindusbim commented 5 months ago

Hi, You can find the sample project below Regards michael Revit 2022 - Test flange cretor.zip

shtirlitsDva commented 5 months ago

Hi The problem was that the flange family must have its' DN size controlled by parameter 'Nominal Diameter 1', it is expected by the code. I've added warnings to the code to warn the user if the parameter is not found. So I changed the name of the parameter 'DN' to 'Nominal Diameter 1'. Also, I had to delete the connectors and make the family use diameter instead of radius, because the program couldn't write to 'Nominal Diameter 1' as it was controlled by the 'RN' parameter. So I changed that so it is the other way around. No the program works.

If these changes in families are not acceptable for you, you can modify the code, it is only a couple of places you need to change it to suit your needs. Revit 2022 - Test flange cretor.zip

mcindusbim commented 5 months ago

Hi, Thank you very much, I will try it

mcindusbim commented 5 months ago

1/it works fine, but the connectors were not connected automatically, normal? 2/You think it is possible to change the cap (fitting) with another like multi-port (fitting) ?

shtirlitsDva commented 5 months ago
  1. yes, I didn't add the code to connect the new parts. I have a utility that connects everything Connect the Connectors, I think it is named.
  2. Not with current code. The code expects something very specific before it works. BUT, it can be modified to fit your needs. You need to outline the logic you need and then express it with code.
mcindusbim commented 5 months ago

Thank you very much for your help and the time spent.