search

shts / StoriesProgressView

show horizontal progress like instagram stories.
Apache License 2.0
885 stars 204 forks source link

Update Readme and build.gradle #15

Closed teresaholfeld closed 6 years ago

teresaholfeld commented 6 years ago

I noticed that when the progress view starts running, there is no callback call. To improve the callback mechanism, and fix #10 and #5, I changed it so that it calls onNext() already when it starts, rather than when it finishes. The reverse method should be the same.

This also brings the gradle and plugin versions up-to-date. I didn't find an option to increment the library version. This is a breaking change, so it should be 4.0.0 now.

shts commented 6 years ago

👀

shts commented 6 years ago

Thank you so much your PR. I have checked it.

First of all. Thanks for update README.md and Gradle. It help for me very much.

But I found that it have a issue. When skip a view, it is not working well. It seems to be flickering. I guess that it's skipping two times.

And, onNext means that progress is finishing. does not mean progress starting. If people that use this library does not understand this mean, I should reconsider about callback name. If #10 or #5 issue was made a mistake in meaning onNext, must rename callbacks...

So, I want to merge README.md and Gradle but do not want merge new callback mechanism. I woud be happy if PR that updating only README.md and Gradle.

Thank you @teresaholfeld

teresaholfeld commented 6 years ago

I am using your library in my project, and realized, it works fine without onNext() already being triggered. So I see your point. I reverted the last commit, so it just includes the README and build.gradle now.

shts commented 6 years ago

@teresaholfeld Thank you very much 🙏