shu223 / PulsingHalo

iOS Component for creating a pulsing animation.
MIT License
1.77k stars 240 forks source link

Multiple pulsing layer class not in cocoapod #21

Closed samjarman closed 8 years ago

samjarman commented 9 years ago

Line 10 here: https://github.com/shu223/PulsingHalo/blob/master/PulsingHalo.podspec needs adjusting :)

hdmchl commented 9 years ago

Line 10 is fine. It looks like the central CocoaPods spec is a little old and needs to be updated (https://github.com/CocoaPods/Specs/blob/master/Specs/PulsingHalo).

@shu223: Please see this guide for updating: https://guides.cocoapods.org/making/specs-and-specs-repo.html#how-do-i-update-an-existing-pod

In the mean time, we can use this in our Podfile: pod 'PulsingHalo', :git => 'https://github.com/shu223/PulsingHalo.git', :tag => '0.0.5'

EDIT: I dropped the :tag to actually get the latest version. 0.0.5 seems to be tagged to version 0.0.4

Similar to: https://github.com/shu223/PulsingHalo/issues/12

simonbromberg commented 9 years ago

Does the MultiplePulsingHalo work for you? It just comes up as a solid, non animating circle for me

samjarman commented 9 years ago

@simonbromberg nah it didnt work for me

hdmchl commented 9 years ago

@simonbromberg @samjarman it works for me. I definitely had a similar issue (non-animating solid circle), but I can't quite remember what it was that fixed it. Have a good look at the example and make sure that's working for you.

EDIT: I remembered. I was using:

[_multiHalo setBackgroundColor:[[UIColor blackColor] CGColor]];

When I should have been using:

[_multiHalo setHaloLayerColor:[[UIColor blackColor] CGColor]];
revolter commented 9 years ago

@shu223 Doesn't this mean that the color section from the documentation in the README is incorrect?

shu223 commented 8 years ago

Please try the new release 0.0.6.