Closed liwt31 closed 1 year ago
I may work on the tutorial module while you finish the time evolution part. @jjren
Patch coverage: 79.38
% and project coverage change: -0.53
:warning:
Comparison is base (
87dc576
) 85.27% compared to head (4a03f1d
) 84.74%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi Weitang @liwt31 , at the beginning of this PR, you mentioned the Heisenberg tutorial bug, but I didn't find any changes to the Heisenberg tutorial. What I found is that the jupyter notebook of Heisenberg tutorial is supposed to move into doc/source/tutorial, but it doesn't.
Did I do something wrong during the force push ...
or you haven't move the jupyter notebook of Heisenberg into doc/source/tutorial?
My another question is what the difference between the three CI tests. From my understanding, ci / test (pull request) is the PR branch + master, ci / test (push) is the PR branch only. Then what is ci/circleci ?
Hi Weitang @liwt31 , at the beginning of this PR, you mentioned the Heisenberg tutorial bug, but I didn't find any changes to the Heisenberg tutorial. What I found is that the jupyter notebook of Heisenberg tutorial is supposed to move into doc/source/tutorial, but it doesn't. Did I do something wrong during the force push ... or you haven't move the jupyter notebook of Heisenberg into doc/source/tutorial?
I found that in the successful ci/circleci run, it showed that
Running Sphinx v5.3.0
copying ../../example/1D-Heisenberg.ipynb
making output directory... done
How did it happen? I can't find a rule anywhere in the package to do this.
Hi Weitang @liwt31 , at the beginning of this PR, you mentioned the Heisenberg tutorial bug, but I didn't find any changes to the Heisenberg tutorial. What I found is that the jupyter notebook of Heisenberg tutorial is supposed to move into doc/source/tutorial, but it doesn't. Did I do something wrong during the force push ... or you haven't move the jupyter notebook of Heisenberg into doc/source/tutorial?
I found that in the successful ci/circleci run, it showed that
Running Sphinx v5.3.0 copying ../../example/1D-Heisenberg.ipynb making output directory... done
How did it happen? I can't find a rule anywhere in the package to do this.
Oh, finally, I found it in /home/jjren/Code/Renormalizer/doc/source/conf.py
!
The remaining question is that
In general looks good! Only need to resolve the problem of the default thread number.
Finally. :turtle:
great stuff, thanks! Just a reminder: the document still needs a lot of work.
update @ 2023.4.8 @jjren
remove the m_max argument in _update_mps in mp.py. First, because it is duplicated with mps.compress_config. The more important reason is that if we want to adaptively control the bond dimension by truncation threshold in the two-site tdvp-ps or ground state algorithm, the former implementation can not achieve that. (What I haven't modified is OFS algorithm because one loss function depends on m_max, so I added an assertion to make sure the bond dimension is fixed.)
add scipy ivp solver company to Krylov solver in the tdvp related evolution algorithm. This will make the evolution algorithm suitable for non-Hermitian operators.
add quadrature in SineDVR basis by using the sympy expression to support more operators. This feature is only experimental, not fully tested.
bump up dependencies (numpy, scipy) in requirement.txt