search

shuaiwangheight / mp4v2

Automatically exported from code.google.com/p/mp4v2
Other
0 stars 0 forks source link

Flag 'podcast' not supported by the 'mp4tags' utility #61

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?

1. Run mp4tags
2. See that the "podcast" flag is not one of the possible settable flags.
3. Download an MP4 podcast file. One example is the MDN Podcast 
<http://feeds2.feedburner.com/TheMdnShow>
4. Run 'mp4info' on one of the downloaded podcast file.
5. Notice that one of the information returned will be "Podcast: YES" (refer to 
the attached screenshot).

What is the expected output? What do you see instead?

The command line tool mp4tags is able to set the podcast flag.

What version of the product are you using? On what operating system?

MP4v2 trunk-r355 -- Mac OS X 10.6.4

Original issue reported on code.google.com by sasmito....@gmail.com on 30 Jun 2010 at 9:19

Attachments:

GoogleCodeExporter commented 8 years ago 
I have a fix for this (patched file attached).  Anybody can help merge it into 
the trunk?

Thanks.

Original comment by sasmito....@gmail.com on 1 Jul 2010 at 3:08

Attachments:

GoogleCodeExporter commented 8 years ago 
I can look into this late next week; on vacation at the moment.

Thanks

Original comment by kid...@gmail.com on 2 Jul 2010 at 10:56

GoogleCodeExporter commented 8 years ago 
I think this change looks fine, but there's one issue--in trunk, 'p' has been 
reserved for playlist, which was added in r380.

See:

http://code.google.com/p/mp4v2/source/diff?spec=svn388&r=380&format=side&path=/t
runk/util/mp4tags.cpp&old_path=/trunk/util/mp4tags.cpp&old=341

I'll try and put in this change today with the first available short letter.

Original comment by kid...@gmail.com on 8 Jul 2010 at 2:24

GoogleCodeExporter commented 8 years ago 
Okay, this was merged into trunk.  It should be in r389.  Because "p" was 
taken, I used the next available letter, which was "B" (of course, you can 
still use -podcast for the long arg).

Please test it out and let me know if it works for you.  Thanks!

Original comment by kid...@gmail.com on 22 Jul 2010 at 5:57

GoogleCodeExporter commented 8 years ago 
Cool thanks.

Original comment by sasmito....@gmail.com on 22 Jul 2010 at 11:54