search

shub39 / Rush

Android app to search, save and share lyrics like spotify! 💫
GNU General Public License v3.0
203 stars 9 forks source link

F-Droid build not reproducible #6

Closed linsui closed 1 month ago

linsui commented 2 months ago

Can you clean the cache and rebuild the apk?

shub39 commented 2 months ago

done on latest release

linsui commented 2 months ago

Thanks!

linsui commented 1 month ago

1.1.0 assets/dexopt/baseline.prof is not reproducible. Not sure why.

shub39 commented 1 month ago

cleaned cache and rebuilt 1.2.0

linsui commented 1 month ago

It's fixed, thanks!

licaon-kter commented 1 month ago

and again https://monitor.f-droid.org/builds/log/com.shub39.rush/10#site-footer

/LE: difflog: rush10.log

fyi https://gitlab.com/fdroid/fdroiddata/-/commit/04f0ccea1817a9902b636514547a5f99f05b4742

shub39 commented 1 month ago

cleaned caches and rebuilt from tag. Will building the app from github actions prevent this?

linsui commented 1 month ago

You just need to remember to clean cache before release. :) CI helps of course. It's fixed, thanks!

licaon-kter commented 1 month ago

do reopen, ref: https://gitlab.com/fdroid/fdroiddata/-/jobs/7580679226#L1159

difflog: rush12.log

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/71e6ef86e7beb052f63e56db3003ea9ccd7178eb

IzzySoft commented 4 weeks ago

@shub39 confirm RB failure. That APK was not build from a clean tree at the commit the tag points to. It has the previous commit hash embedded – but even building at that it fails. So you've most likely built it from a dirty tree somewhere between the two commits.

Please take a look at our hints on reproducible builds, and take special care for the "first basic rule" :wink: "Violating" that one is the most frequent cause of failing RBs.

shub39 commented 4 weeks ago

Done, Sorry I totally forgot about that will make sure this never happens again. Thanks again for putting up with me 🫠

IzzySoft commented 4 weeks ago

Looking forward to the next release being RB again then – while LK will need to know which commit to build and which APK to match it on :wink:

licaon-kter commented 4 weeks ago

while LK

@IzzySoft ?

IzzySoft commented 4 weeks ago

@licaon-kter how do you know what commit to build and what APK to compare against? As you won't suggest to drop and recreate the release (we agreed that's a bad idea, right?), the only other alternative would be to disable this release on your end. Or what did I miss?

licaon-kter commented 4 weeks ago

Will wait for 1.8.0, I see commits already bumped the version anyway