search

shubhadip / vuejs3-datepicker

vue 3 datepicker. supports disabling, highlighting of dates and programmatic access of date.
https://vuejs3-datepicker.netlify.app/
MIT License
69 stars 41 forks source link

Do not style html elements #30

Closed ahoiroman closed 2 years ago

ahoiroman commented 2 years ago

Do not style html elements like body, a, ... as it could destroy an web-apps look & feel

shubhadip commented 2 years ago

so this global css is affecting the whole parent project ? is that what you are trying to say ?

ahoiroman commented 2 years ago

Yes. In my project I am using tailwindcss and I have to set !important to the font-type for the <body> to avoid this problem. I think it would be a more elegant solution to avoid adding styles to the html tags itself, but - if necessary - add them as classes like .datepicker-body

shubhadip commented 2 years ago

okay, ideally this shouldn't be happening bcoz css related to body shouldn't be bundled in library. Removing css completely will break the demo page of the library let me check if there are some unnecessary css bundling happening in the library.

shubhadip commented 2 years ago

this PR will probably fix this issue : https://github.com/shubhadip/vuejs3-datepicker/pull/31

shubhadip commented 2 years ago

:tada: This PR is included in version 1.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: