search

shubham1172 / remote-play

Media controller for PC
MIT License
31 stars 28 forks source link

Add right mouse button click support #27

Closed shubham1172 closed 2 years ago

shubham1172 commented 2 years ago

Double tap to click RMB should be added.

harshlancer commented 2 years ago

I want to work on this issue can you tell me more about it.

shubham1172 commented 2 years ago

@harshlancer sure! If you use remote-play, it currently supports two actions with the touchpad - moving the cursor, and left mouse button click (single tap). With this issue, we want to add support for right mouse button click. It will involve

  1. Adding a hammer event listener for double tap that emits a web-socket message in index.js
  2. Updating the text in touchpad area to indicate double-tap as a supported gesture, in index.html
  3. Translating the new web-socket message to right mouse button click using PyAutoGui in main.py
  4. And finally, updating the Readme to reflect the same in README.md

Let me know if you want to take this up, I will assign the issue to you.

harshlancer commented 2 years ago

@shubham1172 I can do it but I'll need tons of guidance as I've no experience in this field. I know how to code on JS. If you'll allow me I can start working.

shubham1172 commented 2 years ago

Sure @harshlancer! You can start with the code-pointers I shared above to extend the functionality. It will be similar to how left mouse button click is implemented. I have assigned this issue to you.

harshlancer commented 2 years ago

Ok thankyou very much I'll report to you shortly.

tesla-srt commented 2 years ago

I've had a look at the documentation you provided. I'd like to take a crack at it too, if possible :)

shubham1172 commented 2 years ago

@tesla-srt, it is currently assigned to @harshlancer. If they don't have bandwidth by the next few days, we can assign this to you.

shubham1172 commented 2 years ago

@tesla-srt, let me know if you want to take it up, this issue is up-for-grabs again.

Emeka-Ugbanu-hub commented 2 years ago

I would love to help with this also

tesla-srt commented 2 years ago

Alright, let's do it! I'll clone the codebase this evening and take a wack at it :) Are there any specific tests that are being used that I can run?

shubham1172 commented 2 years ago

@tesla-srt, we don't have any test cases as of today, but you can do manual testing to ensure (1) new feature works and (2) old features are not broken.

shubham1172 commented 2 years ago

@Emeka-Ugbanu-hub I have assigned this to @tesla-srt based on a first-come basis. Thanks for showing interest in helping, you can try to pickup other issues in this repo as well.

Emeka-Ugbanu-hub commented 2 years ago

Ok Thanks

tesla-srt commented 2 years ago

Thanks for the patience - Just touched up the changes you mentioned in the latest commit 👍