shubham1172 / remote-play

Media controller for PC
MIT License
31 stars 28 forks source link

PR for #30 #33

Closed JasonT1085 closed 2 years ago

JasonT1085 commented 2 years ago

PR for Issue #30

shubham1172 commented 2 years ago

Thank you @JasonT1085 for your contributions!! I just had a few concerns

  1. It's not working in my local system, is it working for you?
  2. Can we make the box appear as one, and provide instructions a little differently? It seems a little too crowded (note, this can be tracked separately also, I would actually prefer to not block you for this).
JasonT1085 commented 2 years ago

Hi! Scrolling should work as intended now. For the Touchpad Appearance, is this what you mean by appearing as one? I will update the appearance if necessary. Are the instructions better here? With Borders

shubham1172 commented 2 years ago

Yes @JasonT1085 , this is way better.

What if we get rid of the text? Please excuse the quick Paint job:

screenshot

Actually we can get rid of the arrows too. Users of remote-play read the documentation before cloning and running the application, so this might just work. In future, when we ship executables directly for non-technical users, we can include some kind of usage instructions for first time users. What do you think?

JasonT1085 commented 2 years ago

I like it without the text! It looks much cleaner aesthetically. Also, I agree with that last part. Perhaps alongside the gear icon as mentioned in issue #32, there could be a '?' icon, and clicking it would pop up the instructions?

shubham1172 commented 2 years ago

Agreed. That works!

JasonT1085 commented 2 years ago

I believe that should be everything unless you have any more feedback to give?

shubham1172 commented 2 years ago

Thanks again for your contributions @JasonT1085!

JasonT1085 commented 2 years ago

Of course! Thank you for your patience and for having me on this project!

shubham1172 commented 2 years ago

Pleasure, look forward to more contributions 😄