search

shubham1172 / remote-play

Media controller for PC
MIT License
31 stars 28 forks source link

PR for #34 #37

Closed idofish closed 2 years ago

idofish commented 2 years ago

PR for issue #34

idofish commented 2 years ago

Happy to help :)

shubham1172 commented 2 years ago

Since it's expected, I'd think of it as an info message instead of an error.

On Wed, Mar 9, 2022, 9:02 PM idofish @.***> wrote:

@.**** commented on this pull request.

In main.py https://github.com/shubham1172/remote-play/pull/37#discussion_r822777051 :

@@ -44,7 +44,12 @@ async def websocket_endpoint(websocket: WebSocket): except WebSocketDisconnect: print("Client disconnected.") break

  • await websocket.close()

  • Since we're already handling the specific exception above and logging the exception

  • we can suppress pylint W0703 - Catching too general exception Exception (broad-except)

  • except Exception as error: # pylint: disable=W0703
  • print(f"ERROR: {error}")

Should I change the color of the other print? (the one for the client disconnect)

— Reply to this email directly, view it on GitHub https://github.com/shubham1172/remote-play/pull/37#discussion_r822777051, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFI3RUHQSNSUYDJLLEQXE6TU7DABLANCNFSM5QJWGANA . You are receiving this because you commented.Message ID: @.***>