search

shubham1637 / DIAlignR

This is a R package for alignment of DIA mass-spec data
5 stars 1 forks source link

Chromatogram Directory #12

Closed singjc closed 3 years ago

singjc commented 3 years ago

Is it possible to change the assumed chromatogram files folder to something more general? Like xics or chromatograms? Because I usually store my sqMass files in a folder called sqmass, not mzml since they're not mzML files, which causes an issue with get_filenames.R#L84.

It's not a problem to just rename the folder to mzml, more so just a personal preference..

shubham1637 commented 3 years ago

Right. I think we can change the name to xics. Currently, I have both .chrom.mzML and .chrom.sqMass files in mzml folder. I provide a flag to decide which file type to choose. You can change the name and create pull request. I can merge it then

singjc commented 3 years ago

Great, I made a PR.