search

shubham49 / react-pwa

https://boiling-garden-46399.herokuapp.com
MIT License
0 stars 5 forks source link

swipe to delete #5

Open shubham49 opened 4 years ago

shubham49 commented 4 years ago

functionality when users swipe on task then it deletes it

rohan2734 commented 4 years ago

hey i would like to work on this issue, can you mention what and where you want to delete?

shubham49 commented 4 years ago

Whenever user swipes right on the task, then it deletes from the list

rohan2734 commented 4 years ago

ok i would like to implement this and work on this issue, can you assign me ?

shubham49 commented 4 years ago

You can raise PR against this

rohan2734 commented 4 years ago

ok but if you can assign me i can start working on it, becuase when some other person may again ask to work on this issue right?

rohan2734 commented 4 years ago

@shubham49 thanks, and i would raise the PR soon but , please merge it on the dates of october only.

rohan2734 commented 4 years ago

hey @shubham49
I have done npm install, but I have this error, what packages do i need to install more?

npm ERR! sharp@0.23.4 install: `(node install/libvips && node install/dll-copy && prebuild-install) || (node-gyp rebuild && node install/dll-copy)`

npm ERR! Failed at the react-pwa@2.2.10 start script.
shubham49 commented 4 years ago

Delete node_modules, package-lock.json and run npm i

rohan2734 commented 4 years ago

i need to fork the repo and then commit right?

shubham49 commented 4 years ago

Yes, fork the repo commit your changes on branch, push them on your fork, then raise PR

rohan2734 commented 4 years ago

Delete node_modules, package-lock.json and run npm i

that wouldnt solve i think, what do i need to do for that? are you facing the same issue? do we need to seperately install react-pwa like create-react-app? and what about sharp?

Please help me in the setup, i am still facing the same issue.

shubham49 commented 4 years ago

@rohan2734 you need to just run npm install, no other package needs to be installed.

rohan2734 commented 4 years ago

@rohan2734 you need to just run npm install, no other package needs to be installed.

ya i just did that still the errr exists.

shubham49 commented 4 years ago

try running npm cache clean --force before installing node modules

rohan2734 commented 4 years ago

@shubham49 it is not because of that, i think i need to install some react-pwa cli.

shubham49 commented 4 years ago

@rohan2734 you don't need that. everything is in package.json that is required.

rohan2734 commented 4 years ago

@shubham49 ya but idk why it is showing errors.