search

shubhamV123 / react-resume-builder

A simple react application to create your resume based on dynamic configuration
https://resume-builder-react.netlify.app/
MIT License
12 stars 1 forks source link

Conversion to JSON Resume standard #3

Closed Jovany1543 closed 3 years ago

Jovany1543 commented 3 years ago

Description

First of all thank you that you took interest in this project. Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # Lack of compliance with JSON Resume standard

Changed the structure of existent JSON to match that found here. Added several Components to maintain the same level of functionality. Aesthetic changes to the front end will be needed.

Type of Change

Please delete options that are not relevant (including this descriptive text).

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Tested by entering data into the JSON while the app was running to verify it would be updated on the resume. No further tests were performed.

shubhamV123 commented 3 years ago

Hi @Jovany1543 appreciating your effort for doing this. When I wrote this code it was not optimized one. I just wanted to use as MVP. And couldn't get much time to refactor it. Will try to fix and merge in this week. Thanks again!

I agree with @ArielCalisaya . Currently code has lot of duplication. @Jovany1543 Can you look if you can make more modular of this. As always you can always put your idea forward. I am looking forward to give more time on this project.

@Jovany1543 @ArielCalisaya I am thinking of adding new feature. What would you prefer as a user:

  1. Different resume layout if user click on different layout it should render new one in preview mode

  2. Drag and drop section with style option. Think as a editor where user can select and updated font,color etc along with drag option

    or any feedback is welcome!

ArielCalisaya commented 3 years ago

@shubhamV123 In my preference I like the 2nd option

Jovany1543 commented 3 years ago

Feedback acknowledged.

Jovany1543 commented 3 years ago

All feedback was applied.

shubhamV123 commented 3 years ago

@Jovany1543 Have updated and merged your PR along with new changes I also have done. There are few changes which also required. Moving this conversation to that PR. New PR along with your code: https://github.com/shubhamV123/react-resume-builder/pull/5