Compile errors - Githubissues

khoaipx commented 5 years ago

Dear @shubhamagarwal92,

There are some compile errors:

You didn't declare param args for function evaluate at line 64 but called it at line 106.
At line 87, Bridge class only has 2 params hidden size of encoder and decoder, but you declared 3 arguments: hidden size of encoder, decoder and activation function.
Besides, I got some troubles with 2 KB Encoders. I tried to run _train_and_translate_shah_etal.sh. It means that I didn't use kb encoders, but they were initialized. However, param _vocabsize was assigned None value.

I think you should re-run your code with all configurations to guarantee that your code works well.

Thank you so much for your supporting.

shubhamagarwal92 commented 5 years ago

Resolved with #9. Thanks @githwd2016 :)

shubhamagarwal92 commented 5 years ago

Closing this now. Please re-open if it still persists.

shubhamagarwal92 / mmd