search

shubhi1407 / ng2-notify-popup

A simple, lightweight module for displaying notifications in your Angular 4 app.
https://shubhi1407.github.io/ng2-notify-popup/
13 stars 9 forks source link

Are you going to update to Angular 5? #9

Open AdGalesso opened 7 years ago

AdGalesso commented 7 years ago

Are you going to update to Angular 5?

Hesesses commented 7 years ago

this lib seems to be dead =/

AdGalesso commented 7 years ago

Yeah, that's sad... I loaded into the project directly, The problem was in the getRootViewContainer() method. I fixed...

    getRootViewContainer(): ComponentRef<any> {
        if (this._container) return this._container;

        const rootComponents = this.applicationRef.components[0];
        if (rootComponents) return rootComponents;

        throw new Error('View Container not found! ngUpgrade needs to manually set this via setRootViewContainer.');
    }

Now I can update to 5.0,1 \o/

kneczaj commented 6 years ago

I forked the project, and updated it to Angular 5. You can get it here: https://github.com/turbo-team/turbo-notify-popup https://www.npmjs.com/package/turbo-notify-popup

I haven't checked against Angular 6, but this is in plans :)