add favicon of rocketchat in GSoC-Contribution-Leaderboard

shubhsherl / GSoC-Contribution-Leaderboard

This project is now moved to Node.js version and maintained https://github.com/lolimay/GSoC-Contribution-Leaderboard-Node.

https://gsoc.rocket.chat

MIT License

15 stars 16 forks source link

Open avsingh999 opened 5 years ago

Sing-Li commented 5 years ago

Great idea!!! @avsingh999 can you add it as an "Easy first task" contribution to this project?

avsingh999 commented 5 years ago

@Sing-Li yes sure I will send pr soon. thanks : )

avsingh999 commented 5 years ago

@Sing-Li @shubhsherl I try to solve this issue but find there is already add favicon but it's not working on my chrome browser but it's working on my Mozilla (Nightly). So Can you please check this on your chrome. https://github.com/shubhsherl/GSoC-Contribution-Leaderboard/blob/420f053391a0bc76a74b15da9f21c246ef9997a0/GSoC-Contribution-Leaderboard/templates/base.html#L22 thanks : )

shubhsherl commented 5 years ago

@avsingh999 Thanks for pointing it out, Yes it is not working in Chrome. :thinking:

Jaya738 commented 5 years ago

@avsingh999 I think using vendor prefixes may help with browser compatibility.