shuding / nextra

Simple, powerful and flexible site generation framework with everything you love from Next.js.
https://nextra.site
MIT License
11.27k stars 1.23k forks source link

Use Holocron as default editor for the `Edit this page` link #2552

Open remorses opened 9 months ago

remorses commented 9 months ago

Hey, i am working on Holocron, a WYSIWYG Markdown editor that can edit any markdown file on Github (automatically creates a fork, branch and PR with 1 click)

For example you can use this link to make changes to the Nextra markdown files: https://holocron.so/github/pr/shuding/nextra/main/editor/README.md

Can i open a PR to use Holocron as default editor for the Nextra edit this page link?

This workflow is much faster compared to manually using Github to fork, create a branch and create a PR. It also allows people that don't know MDX or Markdown to make changes very easily.

dimaMachina commented 9 months ago

Your work looks incredible 👏, but I would like to stay with the default way

particular users still could override it in favour of Holocron with editLink.component option https://github.com/shuding/nextra/blob/66798f8e7f92cca80f2d62d19f9db5667bcc62ef/packages/nextra-theme-docs/src/constants.tsx#L203-L212

remorses commented 9 months ago

Ok, what do you think about adding 2 links like the following image?

Or maybe a commented out example code in the create-nextra-app template?

Screenshot 2023-12-02 at 11 07 04

I think an WYSIWYG editor would help a lot of less technical people to contribute to docs

arvinxx commented 6 months ago

@remorses Holocron are great! 😋 We have use it in LobeChat 's document site

image