shueja / Monologue

21 stars 7 forks source link

Add support for SwerveModuleState #3

Closed Gold872 closed 11 months ago

Gold872 commented 1 year ago

WPILib supports it as a struct, and it's incredibly useful to log

oh-yes-0-fps commented 11 months ago

Wpilib does not support it as a struct, that's Advantage Kit that does

Gold872 commented 11 months ago

I believe it is getting added in a future update, but if it's not then could you possibly add a custom schema so it can log to the advantagescope format?

oh-yes-0-fps commented 11 months ago

Any object thats a struct can be logged automatically right now. The amount of work to add an exception for a specific object is not at all proportional to benefit and is awful for maintainability of code.

Gold872 commented 11 months ago

Looking at the source code for the kinematics classes there is going to be support for SwerveModuleState, SwerveModulePosition, and a few other kinematics classes in the next release

shueja commented 11 months ago

Now that that beta has been released, we're planning on expanding logging support to any object that has a struct.