search

shuhaowu / remote-for-pianoteq

GNU Affero General Public License v3.0
16 stars 4 forks source link

<select> for bpm #4

Closed creaktive closed 2 years ago

creaktive commented 2 years ago

Fixes the _"TCP: request_sockTCP: Possible SYN flooding on port 8000. Sending cookies. Check SNMP counters." warnings in dmesg. While manually editing the metronome bpm on a phone, too many change events are dispatched. Not good.

creaktive commented 2 years ago

SYN flood happens with iPhone/Safari. Anyways, I've been using this version for a while now, and from the usability perspective it makes much more sense to me. Usually I start practicing with a lower BPM for warming up, then increase it bit by bit. Typing the new BPM every minute or so is annoying. I thought about making increment/decrement buttons for BPM, but then 120 bpm and 121 bpm are essentially the same thing. Dropdown menu with a list, just like PianoTeq does it, seems to be the optimal thing for everyday use. But then of course every now and then it would be great to just type the BPM. I added support for this via window.prompt() in the latest commit.

shuhaowu commented 2 years ago

Thanks!

shuhaowu commented 2 years ago

@creaktive Out of curiosity, are you interested in being an owner/editor for this repo so you can merge your own PR? It might be a bit more convenient, especially since I don't currently use this software every day anymore. I can do any review if you want, of course.

creaktive commented 2 years ago

Thanks @shuhaowu, I would definitely appreciate that :)