search

shuhei / babel-plugin-angular2-annotations

A babel transformer plugin for Angular 2 annotations
80 stars 9 forks source link

Update to Babel 6.0 #6

Closed shuhei closed 8 years ago

PatrickJS commented 8 years ago

:+1:

shuhei commented 8 years ago

Still sending patches to Babel itself to make it work...

gutenye commented 8 years ago

:+1:

Swiip commented 8 years ago

:+1:

shuhei commented 8 years ago

I cannot upgrade to Babel 6 until Babel 6 implements decorators again. Its decorators don't work right now.

Please see #7 for more details.

shanestillwell commented 8 years ago

Would including this plugin work for making Babel transform decorators? https://github.com/babel/babel/tree/master/packages/babel-plugin-transform-decorators

shuhei commented 8 years ago

@shanestillwell No, it doesn't work correctly.

Some folks re-implemented Babel 5 decorators as a Babel 6 plugin. It should work. I'm gonna try it this month. https://github.com/loganfsmyth/babel-plugin-transform-decorators-legacy

amcdnl commented 8 years ago

@shuhei FYI - I tried it w/ legacy decorators and your babel6 PR code, does not work :( . http://www.screencast.com/t/XdEAKf6FhdB

shuhei commented 8 years ago

@amcdnl Thanks for trying! Probably I'll be able to take a look at it this weekend...

shuhei commented 8 years ago

Thanks guys, now upgraded to Babel 6!

PatrickJS commented 8 years ago

:+1: awesome!