shuhei / material-colors

Colors of Google's Material Design made available to coders
https://shuheikagawa.com/material-colors/
ISC License
270 stars 41 forks source link

Test Fails on Windows #17

Closed otariidae closed 7 years ago

otariidae commented 7 years ago

OS: Windows7
Node: v7.4.0
Error Message:

[...]
Error: Command failed: (my directory)\material-colors\node_modules\.bin\rollup -f es (my directory)\material-colors\test\fixtures\default-import.js | (my node dirctory)\node.exe
[...]
    at checkExecSyncError (child_process.js:490:13)
    at execSync (child_process.js:530:13)
    at (my dirctory)\material-colors\test\module.js:18:16
    at Array.forEach (native)
    at Object.<anonymous> ((my dirctory)\material-colors\test\module.js:9:10)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
npm ERR! Test failed.  See above for more details

~Windows does not understand | command, which seems why test fails.~
It may be good to use rollup JavaScript API instead of child_process.execSync and console.log.
[2017/02/09 update]
Windows understands | command. The problem in this case was a space in path as commented below.
Sorry for my misunderstanding.

shuhei commented 7 years ago

Thanks for reporting. It seems a good idea to use JS API.

shuhei commented 7 years ago

Made a change to use rollup JavaScript API and tmp file to remove |. Does it work for you?

otariidae commented 7 years ago

Thank you!
But I have other problems.