shuhei / material-colors

Colors of Google's Material Design made available to coders
https://shuheikagawa.com/material-colors/
ISC License
270 stars 41 forks source link

Replace parsing by 'material-colors-object' module #22

Closed amercier closed 6 years ago

amercier commented 6 years ago

Hi @shuhei!

TL;DR: This PR replace its own parsing by using the material-colors-object.

Description

I made material-colors-object which parses colors from the Official Material Design Documentation page. I think this package is not redundant with yours, it could actually allow separation of concerns pretty neatly:

Notes

shuhei commented 6 years ago

Hi @amercier, this is great! Thanks a lot for updating the data fetching and taking care of backward compatibility.

I'll leave one minor comment about versioning. Everything else looks good to me!

shuhei commented 6 years ago

Thanks for updating!