search

shuiyouren / sqlitepersistentobjects

Automatically exported from code.google.com/p/sqlitepersistentobjects
0 stars 0 forks source link

-[SQLitePersistentObject areAllPropertiesEqual:] should be deprecated #63

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What version of the product are you using? On what operating system?
r132

Please provide any additional information below.
Its not the job of (nor is it possible for) SQLitePersistentObject to determine 
whether _all_ the 
properties of a subclass are "equal". Subclasses should override -isEqual: as 
required.

The comparison of floats in the method is also wrong. NSNumber can hold more 
than just floats.

Comparison of NSDate instances can be done with the existing API.

The method isn't used in the library code.

The method, in any case, should return YES and NO, rather than TRUE and FALSE.

Original issue reported on code.google.com by j.p.dann on 26 Mar 2009 at 10:28

GoogleCodeExporter commented 8 years ago 
This is a test support method, in our case we need to know if all properties are
equal to say whether the save/load is functioning correctly.

Its a shortcut or helper method

I've removed it from the library code.

Original comment by amle...@gmail.com on 28 Mar 2009 at 3:14

GoogleCodeExporter commented 8 years ago 
Oh cool, thanks for doing that :)

Original comment by j.p.dann on 28 Mar 2009 at 4:19