search

shujataliz / webp

Automatically exported from code.google.com/p/webp
0 stars 0 forks source link

[patch] Fix Windows build, allow Windows+SSE2 build #70

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
First patch gets HEAD to build on Windows (makefile updates, remove zlib 
dependency when WEBP_EXPERIMENTAL_FEATURES is not enabled).
Second patch enables SSE2 support with Visual C++ by adding detection of 
related Visual C++ defines and CPUID intrinsic.

Original issue reported on code.google.com by thecybershadow on 3 May 2011 at 9:47

Attachments:

GoogleCodeExporter commented 9 years ago 
Uploaded patch as  https://review.webmproject.org/2273

Thanks!

Original comment by pascal.m...@gmail.com on 5 May 2011 at 11:48

GoogleCodeExporter commented 9 years ago 
Thanks for doing this! I was starting a similar path (see attachment - no SSE2 
yet), but you beat me :). It has also x64 support and fixes some warnings, what 
I will put in another patch. As for SSE2, I think we want to compile dsp_sse2.c 
with /arch:SSE2 and everything else without it - so that the binary is 
universal and the checks are done runtime. I will work on it (unless you beat 
me again ;) ).

Original comment by mikol...@google.com on 6 May 2011 at 10:15

Attachments:

GoogleCodeExporter commented 9 years ago 
Sorry, it looks like I won't be using webp in my project, so it's all yours :)

Original comment by thecybershadow on 6 May 2011 at 10:58

GoogleCodeExporter commented 9 years ago 
These changes were completed with
https://review.webmproject.org/#change,2399

Mikołaj pointed out that currently it may defeat the runtime check for sse2 on 
32-bit builds currently, so some refinement may still be required.

Original comment by jz...@google.com on 2 Jun 2011 at 5:32

GoogleCodeExporter commented 9 years ago 
> These changes were completed with
> https://review.webmproject.org/#change,2399
> 
> Mikołaj pointed out that currently it may defeat the runtime check for sse2
> on 32-bit builds currently, so some refinement may still be required.
>
Addressed with:
https://review.webmproject.org/#change,2409

I believe this issue can be closed.

Original comment by jz...@google.com on 7 Jun 2011 at 10:33

GoogleCodeExporter commented 9 years ago

Original comment by jz...@google.com on 21 Jun 2011 at 2:50