search

shukerullah / react-geocode

A React module to transform a description of a location (i.e. street address, town name, etc.) into geographic coordinates (i.e. latitude and longitude) and vice versa.
MIT License
207 stars 33 forks source link

Type definition files #24

Open kaityhallman opened 5 years ago

kaityhallman commented 5 years ago

My team is using Typescript with this package. Can we have a type definition file?

shukerullah commented 4 years ago

Hi, can anyone from your team submit PR? It will be helpful.

ziyaddin commented 4 years ago

@pouncyisdead would you like to submit PR?

pouncyisdead commented 4 years ago

I'm still trying to get the type bindings right on this. Sorry for the delay.

On Thu, May 7, 2020 at 9:17 AM Ziyaddin Sadigov notifications@github.com wrote:

@pouncyisdead https://github.com/pouncyisdead would you like to submit PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/shukerullah/react-geocode/issues/24#issuecomment-625354319, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXVDWOIWYXSAWQBEV522UTRQLNJPANCNFSM4HYZ6N5A .

ziyaddin commented 4 years ago

It's okay. I think the current state of the type bindings is good enough.

shukerullah commented 11 months ago

Hello @kaityhallman and @pouncyisdead,

We've added TypeScript type definitions to the latest version. Could you please test the package with your setup and let us know if everything works as expected? Your feedback is valuable!