search

shuklamaneesh23 / cf_helper

CF Helper: A tool built with Next.js and Gemini API to fetch and explain Codeforces solutions using web scraping via Cheerio.
https://cf-helper-peach.vercel.app
15 stars 9 forks source link

Improve : Improved the design on landing page. #18

Closed AMANVISHWAKARMA27 closed 1 month ago

AMANVISHWAKARMA27 commented 1 month ago

The button in the landing page has been made equal to the width of other elements. The placeholders have been aligned correctly. Font-bold -> font-sans for good look.

Below is the screenshot of the page:

image

Fixes : #17

vercel[bot] commented 1 month ago

@AMANVISHWAKARMA27 is attempting to deploy a commit to the maneesh's projects Team on Vercel.

A member of the Team first needs to authorize it.

shuklamaneesh23 commented 1 month ago

Great work, @AMANVISHWAKARMA27! Everything looks good except for the font change. Please revert it to the previous version and let me know once it's done.

Thanks!

AMANVISHWAKARMA27 commented 1 month ago

Sure @shuklamaneesh23 , will do asap

AMANVISHWAKARMA27 commented 1 month ago

@shuklamaneesh23 , i have made the changes as per your requirements. Kindly review them.

![Screenshot from 2024-10-01 20-17-11](https://github.com/user-attachments/assets/25b88af5-203b-4f54-95e9-e6af83aec46e)
![Screenshot from 2024-10-01 20-17-24](https://github.com/user-attachments/assets/aefe992d-309d-4cb0-8453-e2cabaf00d5c)
![Screenshot from 2024-10-01 20-17-40](https://github.com/user-attachments/assets/1f959868-af82-49e9-9539-45eff899328e)
shuklamaneesh23 commented 1 month ago

Dear @AMANVISHWAKARMA27 ,the attachments that you have provided in the PR description are not visible and also make sure to remove that extra dotenv dependency as it is a separate thing. Kindly go through the contributing.md before making such things. Thanks!

AMANVISHWAKARMA27 commented 1 month ago

@shuklamaneesh23 , you can review now.

AMANVISHWAKARMA27 commented 1 month ago

Dear @AMANVISHWAKARMA27 ,the attachments that you have provided in the PR description are not visible and also make sure to remove that extra dotenv dependency as it is a separate thing. Kindly go through the contributing.md before making such things. Thanks!

I have fixed the issue. Please have a look again.

shuklamaneesh23 commented 1 month ago

Great work, @AMANVISHWAKARMA27! I’m closing this issue as it has been successfully resolved. I must say, it’s rare to come across such an enthusiastic contributor who is so dedicated to consistently working on an issue. Your commitment and diligence throughout this process have been truly impressive.

Thank you for your valuable contribution! Looking forward to seeing more of your amazing work in the future!

Keep up the fantastic work! 👏✨