search

shukriadams / arewedown

Simple, customizable HTTP uptime and status checking service.
GNU General Public License v3.0
205 stars 21 forks source link

Allow the application to run behind a rootpath #22

Closed lfoppiano closed 1 year ago

lfoppiano commented 1 year ago

The absolute paths in the views provide constraints on deployment in a local service without DNS control, e.g. configure a simple reverse proxy using Apache. This PR provides a way to add the rootpath from the configuration.yaml (by default it behaves as of now).

shukriadams commented 1 year ago

hey Luca, this is a really useful feature, I'd love to merge it in. Would it be possible though to remove the changes that are unrelated to the rootpath setting - the whitespace changes and dockerfile stuff? I'm asking because I'm in the middle of a big rewrite of the project (https://github.com/shukriadams/arewedown/tree/UI-rewrite) and it will pretty easy for me to integrate your rootpath stuff into the new branch, but all the whitespace stuff will mean a lot more work for me.

lfoppiano commented 1 year ago

Hi @shukriadams thanks! I have some more changes to add and I will cleanup the unrelated stuff. BTW I'm going to set the PR as a draft, till it's ready to review.

shukriadams commented 1 year ago

Sure thing - the UI-rewrite branch will change/clean up a lot of junk in the project, I suggest having a look at that too. I made a lot of UX / quality-of-life improvements to the project.

lfoppiano commented 1 year ago

I'm going to cleanup in a separate branch and open a new PR.