Closed ImpregnableProgrammer closed 1 year ago
We might also need to resolve the many more issues being raised by ESLint now after unignoring the files under the package/*/src
directories (leading the workflow check to fail), but I'm unsure how to reconcile all of those myself at the moment. The unit test for the new custom rule is also not running properly at the moment and I'll try to see why that is.
Ok, I'm not really sure why the workflow check is failing at the moment...
Ah dang, well that still didn't fix the failing workflow, but at least rules testing is implemented correctly now with type information https://typescript-eslint.io/packages/rule-tester#type-aware-testing
Merging #24 (9498572) into main (9c4407b) will increase coverage by
0.71%
. The diff coverage is88.23%
.
@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 86.31% 87.02% +0.71%
==========================================
Files 16 17 +1
Lines 592 609 +17
Branches 70 77 +7
==========================================
+ Hits 511 530 +19
+ Misses 80 77 -3
- Partials 1 2 +1
Files Changed | Coverage Δ | |
---|---|---|
...plugin-choreography-ts/src/no-renaming-operator.ts | 88.23% <88.23%> (ø) |
... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Implemented the custom eslint rule
no-renaming-operator
as specified in issue #19. The error message might need to be tweaked a bit, but the detection works very well at the moment while editing in VSCode with the ESLint extension enabled!