search

shumingch / gnome-email-notifications

Gnome Email Notifications
https://extensions.gnome.org/extension/1230/gmail-message-tray/
GNU General Public License v2.0
85 stars 18 forks source link

Closes #25 #40

Closed jcroskery closed 2 years ago

jcroskery commented 2 years ago

If there is no internet access, Soup will return a status code of either 2 or 3 (see https://gjs-docs.gnome.org/soup24~2.72.0/soup.status#default-cant_resolve). Displaying a "Failed to get authorization" message in this case seems unnecessary.

shumingch commented 2 years ago

Is this still a draft?

On Sun, Dec 5, 2021, 1:30 PM Justus Croskery @.***> wrote:

If there is no internet access, Soup will return a status code of either 2 or 3 (see https://gjs-docs.gnome.org/soup24~2.72.0/soup.status#default-cant_resolve). Displaying a "Failed to get authorization" message in this case seems unnecessary.

You can view, comment on, or merge this pull request online at:

https://github.com/shumingch/gnome-email-notifications/pull/40 Commit Summary

File Changes

(1 file https://github.com/shumingch/gnome-email-notifications/pull/40/files)

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/shumingch/gnome-email-notifications/pull/40, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXJYJWQH5O6JQW7XG6XBE3UPPKWJANCNFSM5JNHGZHQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jcroskery commented 2 years ago

There are two possible errors that can occur when there is no network connection. The GET request that finds unread emails may fail, or the Gnome Online Accounts (GOA) access token may have expired. I only noticed the second error after I created this pull request, so I converted the request into a draft.

The pull request is now ready for review.