search

shunkakinoki / Wallet

🪄 - Open source EVM Wallet
https://wallet.light.so
GNU General Public License v3.0
121 stars 14 forks source link

Import mnemonic as primary in onboarding #5

Closed DimitarNestorov closed 2 years ago

DimitarNestorov commented 2 years ago

As a user coming from MetaMask I assume that when I import a mnemonic and then try to get my second account that it is derived from the imported mnemonic. Instead the app generated a new mnemonic and used that to derive accounts.

Before (click to see a video) I was expecting the second address to be `0x70997970C51812dc3A010C7d01b50e0d17dc79C8` https://user-images.githubusercontent.com/8790386/200383698-65ad4eec-7024-4536-ae72-9bac8438d8ef.MP4
After (click to see a video) https://user-images.githubusercontent.com/8790386/200383805-255c531f-6fd5-4236-a365-a7ef6b9b2427.MP4

The mnemonic I used for testing is test test test test test test test test test test test junk. The first 5 accounts are:

addresses

I tried to use a table but GitHub didn't embed the videos 🤷‍♂️

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: 04402213b767190d26a2c324fa126c1fa66d13e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 2 years ago

@dimitarnestorov is attempting to deploy a commit to the Light Team on Vercel.

A member of the Team first needs to authorize it.

shunkakinoki commented 2 years ago

LGTM! Appreciate the PR