shunwang / numexpr

Automatically exported from code.google.com/p/numexpr
MIT License
0 stars 0 forks source link

better library suffix finding in FindPythonLibsNew #102

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I've been using the excellent FindPythonLibsNew.cmake file that I believe 
originated with numexpr in my own file, and I found that it could not find the 
Python 3.2 library provided by Ubuntu 12.04, because the library name is 
"libpython3.2mu.so".  I've come up with a fix, so I thought I'd contribute my 
patch, even if the issue isn't urgent (or even applicable) for numexpr itself.

I've fixed this by inspecting the distutils.sysconfig variable "LDVERSION", 
which at least on my platform is exactly what we want: "3.2mu".  I believe I've 
made it so it falls back to the usual "$MAJOR.$MINOR" when LDVERSION can't be 
found, but I haven't tested that.

Original issue reported on code.google.com by talljimbo@gmail.com on 14 May 2013 at 3:26

Attachments:

GoogleCodeExporter commented 9 years ago
Mark, could you have a look at this? Thanks

Original comment by gdemen...@gmail.com on 22 May 2013 at 10:37

GoogleCodeExporter commented 9 years ago
I've committed your patch, together with some other tweaks I've done rolled up 
together. It falls back to VERSION instead of to "$MAJOR.$MINOR", as the latter 
didn't work on windows right. Please test it and let me know if it's still 
working for you!

The project I started this file for is here:

https://github.com/ContinuumIO/dynd-python

Original comment by mwwi...@gmail.com on 5 Jun 2013 at 12:57