search

shunwang / numexpr

Automatically exported from code.google.com/p/numexpr
MIT License
0 stars 0 forks source link

Patch for /FindNumPy.cmake #104

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I'm using Continuum's Anaconda and the output of the python command looks like 
this:

Vendor:  Continuum Analytics, Inc.
Package: mkl
Message: trial mode expires in 28 days
1.7.1
/Users/mcgrant/anaconda/lib/python2.7/site-packages/numpy/core/include

This breaks FindNumPy.cmake, which expects the version to the first line, and 
the include directory to be the second.

Original issue reported on code.google.com by m...@cvxr.com on 5 Jun 2013 at 5:13

Attachments:

GoogleCodeExporter commented 9 years ago 
I don't undersand well this patch.  Why _NUMPY_VALUES -2 and -1 are better than 
0 and 1?  I am willing to apply the patch, but can you provide more context for 
this please?

Original comment by fal...@gmail.com on 27 Aug 2013 at 10:54

GoogleCodeExporter commented 9 years ago 
I don't undersand well this patch.  Why _NUMPY_VALUES -2 and -1 are better than 
0 and 1?  I am willing to apply the patch, but can you provide more context for 
this please?

Original comment by fal...@gmail.com on 27 Aug 2013 at 10:54

GoogleCodeExporter commented 9 years ago 
The reason is that sometimes the length of NUMPY_VALUES is longer than 2. (I 
believe I saw this with Anaconda for instance.) And from my experience, when 
that is the case, the values you want are the last two, not the first two.

Original comment by m...@cvxr.com on 27 Aug 2013 at 2:22

GoogleCodeExporter commented 9 years ago 
Okay.  Added your fix in rev 498684d1588b.  Thanks!

Original comment by fal...@gmail.com on 29 Aug 2013 at 7:33