search

shunwang / numexpr

Automatically exported from code.google.com/p/numexpr
MIT License
0 stars 0 forks source link

add min and max functions #120

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 

I've added min and max functions in a clone of numexpr, adamdryan-numexpr.

Hope it helps.

Thanks for all your hard work.  Great package!

Original issue reported on code.google.com by adamdr...@gmail.com on 2 Dec 2013 at 10:31

GoogleCodeExporter commented 9 years ago 
Hi.  I have tested your branch, and it does not pass the test suite.  Could you 
fix that please?  Also, could you add some tests for your added functionality?

Thanks

Original comment by franc...@continuum.io on 3 Dec 2013 at 10:20

GoogleCodeExporter commented 9 years ago 
wow.  So few lines of code, so many errors.  Sorry, I never ran the tests
before.  This will take me a while to figure out what's what.

-A

Original comment by adamdr...@gmail.com on 3 Dec 2013 at 4:40

GoogleCodeExporter commented 9 years ago 
It's difficult for me to understand how I'm breaking things.  I've looked
through the docs and code, but I need some sort of reference for adding
functions.

Original comment by adamdr...@gmail.com on 3 Dec 2013 at 7:27

GoogleCodeExporter commented 9 years ago 
OK, I had a bad syntax error and have fixed the breaking tests.  Now I just
need to add a test...

Original comment by adamdr...@gmail.com on 3 Dec 2013 at 9:01

GoogleCodeExporter commented 9 years ago 
I added two small tests.  Probably need more.

Original comment by adamdr...@gmail.com on 3 Dec 2013 at 9:33