search

shunwang / numexpr

Automatically exported from code.google.com/p/numexpr
MIT License
0 stars 0 forks source link

Potential missing Py_END_ALLOW_THREADS #42

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I've just spotted a *potential* bug (it doesn't seem to cause any problem in 
the usual case):

In interpreter.c (trunk), shouldn't there be "Py_END_ALLOW_THREADS" also on 
lines 1271, 1276, 1279?

Original issue reported on code.google.com by gdemen...@gmail.com on 21 Jan 2011 at 3:03

GoogleCodeExporter commented 9 years ago 
I don't think this is grave, but I have changed the GIL release/get code of 
position to a better place anyway (r271).

Original comment by fal...@gmail.com on 25 Jan 2011 at 11:56

GoogleCodeExporter commented 9 years ago 
Updated to release the GIL also with serial operation (r274).

GIL will not be released when small blocks are used (the win is too little, if 
any).

Original comment by fal...@gmail.com on 25 Jan 2011 at 12:54

GoogleCodeExporter commented 9 years ago 
I was about to suggest this :)

Original comment by gdemen...@gmail.com on 25 Jan 2011 at 1:15