Closed GoogleCodeExporter closed 9 years ago
Hi. Could you try this patch? It *might* fix the issue but since I can't test
it (I don't have MSVC installed), there is a high chance it doesn't.
Original comment by gdemen...@gmail.com
on 4 Oct 2011 at 10:39
Attachments:
Included Gaetan's patch in aff7032692bf (time will say whether this is useful
or not).
Original comment by fal...@gmail.com
on 1 Nov 2011 at 11:47
Oh, sorry, I totally forgot about this.
I tested new release right now, as I see it includes mentioned patch.
Unfortunately I can't compile again, and I added log in attachment
Let me know if anything I can do to test again. I'll take care to be in time
Original comment by klo...@gmail.com
on 2 Nov 2011 at 9:14
[deleted comment]
I attached through GMail, but perhaps it was not delivered.
Here is another one
Original comment by klo...@gmail.com
on 2 Nov 2011 at 11:16
Attachments:
Please consider attached patch for msvc9 issues. All numexpr tests pass on
win32 and win-amd64, py2.6 and py2.7.
Is pytables 2.3.1 supposed to be compatible with numexpr 2.0?
Original comment by cjgoh...@gmail.com
on 3 Nov 2011 at 7:24
Attachments:
Added fix in revision 64c049db262d. Christophe, could you please check that
everything is okay so that I can close the ticket? Thanks!
Original comment by fal...@gmail.com
on 4 Nov 2011 at 12:37
The revision builds and tests well also with VML/MKL.
I found that replacing the `/Ox` option with `/O1`is not really necessary.
Compilation only takes ~20s. A non-critical patch is attached.
Many pytables tests fail because the `necompiler.getContext` function changed
API and raises ValueError for unknown keyword arguments, e.g. `copy_args`.
Original comment by cjgoh...@gmail.com
on 4 Nov 2011 at 5:14
Attachments:
Ok. /Ox used to be a big problem back with MSVC6, but I guess this is a
pre-diluvian beast nowadays. Applied your patch in revision 6b9450050d60.
And yes, I'm aware of the API breaks for PyTables (and other apps). I'm
looking into re-adding the `copy_args` argument ti `evaluate()` again, but
unfortunately, while running the PyTables test suite I've found another, pretty
serious issue:
http://code.google.com/p/numexpr/issues/detail?id=64
Anyway, I'm closing this one. Thanks a lot for your verification!
Original comment by fal...@gmail.com
on 4 Nov 2011 at 5:48
Original issue reported on code.google.com by
klo...@gmail.com
on 20 May 2011 at 8:21