shunwang / redisql

Automatically exported from code.google.com/p/redisql
0 stars 0 forks source link

explicit ARGC for all Redisql commands #18

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Currently INSERT and UPDATE (val_list) have explicit ARGC 

The Where Clause of any SELECT, UPDATE, DELETE as well as the CREATE TABLE 
column_definition list can be any number of arguments.

This is acceptable for the PHP, Ruby, and Node.js clients, but confusing when 
people use the command line (redisql-cli) tool and there have been SEGV's when 
people violate the protocol.

For this reason the commands should be defines as
1.) SELECT cols FROM tbl WHERE clause - argc = 5
2.) UPDATE tbl SET val_list WHERE clause - argc = 6
3.) DELETE FROM tbl WHERE clause - argc = 5
4.) CREATE tbl AS (col_defs) - argc = 4

CreateTableAS and SelectStore need to work w/in this framework also ... most 
likely

5.) CREATE TABLE AS "redis_command redis_args" - argc = 4
6.) "STORE redis_command redis_args" - part of where clause

Original issue reported on code.google.com by jaksprats on 26 Oct 2010 at 5:10

GoogleCodeExporter commented 9 years ago
Bug 15 is encapsulated in this bug

Original comment by jaksprats on 28 Oct 2010 at 8:09

GoogleCodeExporter commented 9 years ago
fixed a while back

Original comment by jaksprats on 4 Jan 2011 at 7:34