search

shuoyangd / tape4nmt

a ducttape workflow for neural machine translation
14 stars 6 forks source link

merge some of mjpost's new features #13

Closed shuoyangd closed 5 years ago

shuoyangd commented 5 years ago

@mjpost do you mind submitting your current master branch as a pull request and let me merge in some features on top of that?

Despite the fact that I don't want to get rid of dummy* and I don't like the new dataset naming scheme, lots of new features (e.g. downloading from sacrebleu://, lowercase, source factor) actually look really cool, and it seems easier to work on top of it than individually copying each part.

Thanks!

mjpost commented 5 years ago

You just want me to submit my current master against your current master?

shuoyangd commented 5 years ago

Yep. Seems like it'll be quite a lot diff, but I'll sort it out.

shuoyangd commented 5 years ago

Ah, I think it's the same if I checkout your master and push to this repo. No need for pull request.