search

shurcooL / Go-Package-Store

An app that displays updates for the Go packages in your GOPATH.
MIT License
899 stars 29 forks source link

If a commit has known comments, display their count and link to them. #29

Closed dmitshur closed 9 years ago

dmitshur commented 9 years ago

Original inspiration is over at https://github.com/shurcooL/Go-Package-Store/commit/f93175e41607f67ba2ded91095bb26fd98ab285e#commitcomment-9233851.

The idea is to add a little unobtrusive comments counter with a link that takes you to comments. Primarily implementation is for GitHub, but in theory it's a general change that other presenters can support too.

image

In the screenshot above, it would link you directly to the comments on that commit:

https://github.com/gopherjs/gopherjs/commit/635a153b2f382fb394a1975f8196b6ca40477950#comments

dmitshur commented 9 years ago

By the way, thanks to @slimsag and @rebyn for inspiring this feature. :D

rebyn commented 9 years ago

Side note: I'm browsing the web interface from quite a big screen, which makes reading commit messages on the left then navigating to its link on the right a bit tough. How do you think about layouting commit link next to the message? Something like:

SHA - Commit Message

dmitshur commented 9 years ago

Side note: I'm browsing the web interface from quite a big screen, which makes reading commit messages on the left then navigating to its link on the right a bit tough. How do you think about layouting commit link next to the message? Something like:

SHA - Commit Message

I think a better solution would be to cap the max-width of the content to something reasonably sane. Right now there is no cap, which I can imagine would make the changes and commit links unreadable and inconvenient.

I don't think putting the commit links on the right side is a good idea, because that information is secondary to the main content: the change message. I want to have more important information on the left, and less important details (if you're interested) to the right.

rebyn commented 9 years ago

I don't think putting the commit links on the right side is a good idea, because that information is secondary to the main content: the change message. I want to have more important information on the left, and less important details (if you're interested) to the right.

UX wise, how about making commit message clickable (link it to GH link)?

dmitshur commented 9 years ago

That might work, I'll give it a try.