search

shurcooL / Go-Package-Store

An app that displays updates for the Go packages in your GOPATH.
MIT License
900 stars 29 forks source link

component: Package doesn’t build with latest Vecty API. #90

Closed mvdan closed 6 years ago

mvdan commented 6 years ago 
$ go build ./...
# github.com/shurcooL/Go-Package-Store/component
component/presentation.go:32:4: undefined: prop.Class
component/presentation.go:37:17: undefined: prop.Class
component/presentation.go:48:17: undefined: prop.Class
component/presentation.go:105:20: cannot use p (type *RepoPresentation) as type vecty.Component in argument to vecty.Rerender:
        *RepoPresentation does not implement vecty.Component (wrong type for Render method)
                have Render() *vecty.HTML
                want Render() vecty.ComponentOrHTML
component/presentation.go:134:18: undefined: prop.Class
component/presentation.go:179:17: undefined: prop.Class
component/presentation.go:194:17: undefined: prop.Class
component/presentation.go:219:17: undefined: prop.Class
component/presentation.go:280:17: undefined: prop.Class
component/updates.go:15:17: undefined: prop.Class
component/updates.go:15:17: too many errors

This is from an up-to-date clone, after doing go get -d on the dependencies. I might be doing something wrong, but I think I should be able to just build this.

Note that building the main binary still works.

dmitshur commented 6 years ago

Thanks for reporting. I haven’t updated it to the new Vecty API yet, but I will soon.

The package that fails it build is only used by frontend. During normal GPS usage, a pre-compiled version of it is used from assets package. That’s why cmd/Go-Package-Store still works.