shurcooL / binstale

binstale tells you whether the binaries in your GOPATH/bin are stale or up to date.
MIT License
146 stars 4 forks source link

Color escape sequences not Windows friendly. #10

Closed ChrisHines closed 7 years ago

ChrisHines commented 7 years ago

Consider using a package such as github.com/fatih/color to provide colors compatible with the Windows console.

dmitshur commented 7 years ago

Thanks for reporting this.

Is it a problem with the standard windows cmd.exe command prompt?

ChrisHines commented 7 years ago

Yes. I experienced the problem on Windows 10 with cmd.exe.

On Sat, Dec 10, 2016, 4:22 PM Dmitri Shuralyov notifications@github.com wrote:

Thanks for reporting this.

Is it a problem with the standard windows cmd.exe prompt?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/shurcooL/binstale/issues/10#issuecomment-266241028, or mute the thread https://github.com/notifications/unsubscribe-auth/ABAvZyFWQwNwI9qjyjOGfHuVjsnLz93Fks5rGxgJgaJpZM4LJv3h .

dmitshur commented 7 years ago

I looked at my use of colors in this tool and realized it's not a good idea. I took them out in cfe7dc1edfec4a1a1d63ae9ad597f5120d1af353. This issue should be resolved as a result.

ChrisHines commented 7 years ago

Yes, it is resolved. Thanks.