search

shuriken-ui / nuxt

Nuxt version of Shuriken UI with ready to use components
https://shurikenui.com/
MIT License
161 stars 22 forks source link

BaseDropdown missing buttonSize prop #128

Closed andyjamesn closed 2 months ago

andyjamesn commented 2 months ago

BaseDrowndown

Missing button size. It is declared in the file but never implemented

<BaseButton
    v-if="variant === 'button' || props.variant === 'button'"
    :color="props.buttonColor ? props.buttonColor : buttonColor"
    :rounded="props.rounded ? props.rounded : rounded"
    class="!pe-3 !ps-4"
>

Should be

<BaseButton
    v-if="variant === 'button' || props.variant === 'button'"
    :color="props.buttonColor ? props.buttonColor : buttonColor"
    :size="props.buttonSize ? props.buttonSize : buttonSize"
    :rounded="props.rounded ? props.rounded : rounded"
    class="!pe-3 !ps-4"
>

I have overridden the component to fix this but would be nice to have it in the core package.

linear[bot] commented 2 months ago

NUI-28 BaseDropdown missing buttonSize prop